Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log without state #268

Merged
merged 1 commit into from
May 1, 2023
Merged

fix: log without state #268

merged 1 commit into from
May 1, 2023

Conversation

berendsliedrecht
Copy link
Member

@berendsliedrecht berendsliedrecht commented Apr 28, 2023 •
edited
Loading

Fixed some of the logs. Some logs do not need a prefix as they are a MUST output for the command. (think of connection id of siera connection receive). Everything else is info, debug or trace.

@codecov
Copy link

codecov bot commented Apr 28, 2023 •
edited
Loading

Codecov Report

Merging #268 (0e21a1a) into main (28d6089) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Impacted Files Coverage Δ
...es/automations/src/automations/credential_offer.rs 0.0% <0.0%> (ø)
crates/cli/src/modules/automation.rs 0.0% <0.0%> (ø)
crates/cli/src/modules/configuration.rs 0.0% <0.0%> (ø)
crates/cli/src/modules/connection.rs 0.0% <0.0%> (ø)
crates/cli/src/modules/credential.rs 0.0% <0.0%> (ø)
crates/cli/src/modules/credential_definition.rs 0.0% <0.0%> (ø)
crates/cli/src/modules/feature.rs 0.0% <0.0%> (ø)
crates/cli/src/modules/multitenancy.rs 0.0% <0.0%> (ø)
crates/cli/src/modules/proof.rs 0.0% <0.0%> (ø)
crates/cli/src/modules/schema.rs 0.0% <0.0%> (ø)
... and 4 more

... and 3 files with indirect coverage changes

morrieinmaas
morrieinmaas suggested changes May 1, 2023
View reviewed changes
Copy link
Contributor

@morrieinmaas morrieinmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. left one comment/suggestion

crates/logger/src/lib.rs Outdated Show resolved Hide resolved
@berendsliedrecht
fix: log without state
0e21a1a 
Signed-off-by: blu3beri <[email protected]>
@berendsliedrecht berendsliedrecht merged commit f20bb83 into animo:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrieinmaas morrieinmaas morrieinmaas approved these changes

@TimoGlastra TimoGlastra Awaiting requested review from TimoGlastra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berendsliedrecht @morrieinmaas